Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo Stream for iPhoto #41

Merged
merged 7 commits into from
Feb 10, 2012
Merged

Photo Stream for iPhoto #41

merged 7 commits into from
Feb 10, 2012

Conversation

jjac
Copy link

@jjac jjac commented Jan 17, 2012

Implementation of the Apple Photo Stream feature for iPhoto, specifically:

  • Add apropriate node if usage of iPhoto 9.2.1 or higher is detected
  • Parse plist for Photo Stream images and display
  • prepare for future (third party) Photo Stream support of Aperture
  • Include English and German localizations

Includes fixes for issues #32 and #39.

Joerg Jacobsen added 7 commits January 6, 2012 11:16
Conflicts:
	de.lproj/Localizable.strings
	en.lproj/Localizable.strings
…ly not appropriately handled by the IMBLibraryController of Master branch (duplicate iPhoto nodes would show up at least on some multi-kernel hardware)
@mikeabdullah
Copy link
Collaborator

I've pulled into the main repo for further testing. Will merge after that.

@terrencetalbot
Copy link
Contributor

I've tested this on the branch. It does work and I'm happy to see it. But I think we need some additional UI.

If you haven't turned on Photo Stream in iPhoto -- as I had not, iMedia Browser displays the Photo Stream choice in the source list, but nothing displays in the actual browser. This was very confusing/disconcerting. I had to launch iPhoto and specifically turn on Photo Stream. Then wait for photos to load. Then quit iPhoto and wait for its cache to be written out. Then reload iMedia Browser and then Photo Stream showed photos. If you don't do this sequence, you just see nothing for Photo Stream even though I could see on my iPhone that there were photos there.

Do we have some way to detect if Photo Stream has actually been turned on? If we do, and it's not been turned on, I'm not sure we should display the choice in the source list.

If we can't do that, then I think that if no photos are shown we should indicate to the user that they need to turn on Photo Stream in iPhoto. (So, in gray text where photos should be, some message to the user.) I really think we need UI to help people get started.

(Also note that Photo Stream can only be activated in iPhoto OR Aperture, but not both at the same time.)

@jjac
Copy link
Author

jjac commented Jan 23, 2012

Hi Terrence,

thanks for your thorough investigation. A couple of remarks:

The roundtrip you descibed one has to take to eventually see the photo stream if the feature was disabled in iPhoto is due to a current bug in iMedia (see issue #33). iMedia should get notified of any change in iPhoto and promptly reload its node tree so you should not have to restart iMedia to get to see your Photo Stream photos. Also, are you sure that you must quit iPhoto to make it rewrite its AlbumData.xml? On my system (OS X 10.7.2, iPhoto 9.2.1) it rewrites it almost instantaneously after a Photo Stream photo was added or a photo got deleted or similar changes occurred.

Nonetheless could it be helpful to know whether Photo Stream is currently turned on in iPhoto or not. I personally know of no way to tell. Even if you turn back off Photo Stream in iPhoto its AlbumData.xml will still claim there are Photo Stream photos currently present (in my case some subset of the photos iPhoto's Photo Stream held before). After I turned Photo Stream back on iPhoto showed two photos (the ones from the stream of this month) while its AlbumData.xml still held the aforementioned subset (including the ones from this month). Every new photo then streamed showed up in both applications.

BTW: iBooks Author doesn't yet incorporate Photo Stream into its media browser. It seems to me that Apple still has to smooth a couple of rough edges here.

If we can't do that, then I think that if no photos are shown we should indicate to the user that they need to turn on Photo Stream in iPhoto. (So, in gray text where photos should be, some message to the user.) I really think we need UI to help people get started.

I like your idea although this would only be displayed if you never had iPhoto Photo Stream turned on before (given what I stated above). Unfortunately I don't have time to implement it myself.

Regarding issue #33: I just commented on its status and intend to submit a fix this week.

Regards, Jörg.

@jjac
Copy link
Author

jjac commented Feb 1, 2012

Hi Mike, have you had a chance to test this pull request yet?

Regards, Jörg.

@mikeabdullah
Copy link
Collaborator

Well Terrence has tested it for us :)
I think our concern remains that it's not as user-friendly as we'd like. I'm going to look at #33 first and come back to this.

@mikeabdullah mikeabdullah merged commit 6487fcb into karelia:master Feb 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants